Skip to content

Commit

Permalink
Make IsrTask a valid CmdLineTask.
Browse files Browse the repository at this point in the history
The IsrTask was not usable as a CmdLineTask, as it was written to be
called as a subtask of ProcessCcdTask.  This allows the default
IsrTask to be retargeted to camera-specific versions of the ISR
processing.  A new IsrWrapperTask now exists to hold IsrTask for
retargetting in standalone processing, and both processCcd.py and
runIsr.py now read from the same configuration files for each obs_
package.  This has involved migrating configuration values from
config/processCcd.py to config/isr.py for many obs_ packages.
  • Loading branch information
czwa committed Sep 10, 2018
1 parent 915e3cf commit a6e67f2
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 3 deletions.
6 changes: 6 additions & 0 deletions config/isr.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
"""
ctio0m9-specific overrides for isrTask
"""
config.doFlat = False # TODO: change for release/when we have flats
config.doLinearize = False
config.doDefect = False # TODO: make defect list and enable
10 changes: 10 additions & 0 deletions config/isrWrap.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
"""
ctio0m9-specific overrides for isrWrapperTask
"""
import os.path

from lsst.utils import getPackageDir

obsConfigDir = os.path.join(getPackageDir("obs_ctio0m9"), "config")

config.isr.load(os.path.join(obsConfigDir, "isr.py"))
11 changes: 8 additions & 3 deletions config/processCcd.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
"""
ctio0m9-specific overrides for ProcessCcdTask
"""
from __future__ import print_function
import os.path
from lsst.meas.algorithms import LoadIndexedReferenceObjectsTask
from lsst.meas.astrom import MatchPessimisticBTask
from lsst.utils import getPackageDir

obsConfigDir = os.path.join(getPackageDir("obs_ctio0m9"), "config")

PIXEL_MARGIN = 2000 # to ensure they're linked, as per DM-11356

config.isr.doFlat = False # TODO: change for release/when we have flats
config.isr.doLinearize = False
config.isr.doDefect = False # TODO: make defect list and enable
config.isr.load(os.path.join(obsConfigDir, "isr.py"))

config.charImage.repair.cosmicray.nCrPixelMax = 100000

Expand Down

0 comments on commit a6e67f2

Please sign in to comment.