DM-18610: Add fields, limited mutability, and trim/assembly-state tracking to cameraGeom #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
force-pushed
the
tickets/DM-18610
branch
from
7b3fac4
to
0ce1a32
Compare
natelust
requested changes
Oct 3, 2019
There was a problem hiding this comment.
Your commit title is too long. There is a comment that is a question which seems to mean its an actionable item. Does that mean this is not really done? Does it mean that there needs to be a ticket spawned? If the latter create the ticket and put that in the comment instead of a question. Fixing it would be even better (if it is trivial) or creating a ticket and then doing it.
The camera config does not set a suspect level, so we should not be doing suspect masking.
|
I've updated the commit to be more direct. It looks like this has relied on the previous amplifier implementation setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now says suspectLevel = 0, which means it blanks everything. Disable doSuspect.