Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to work after camGeom changes in DM-5922 #8

Merged
merged 1 commit into from Sep 23, 2017

Conversation

mfisherlevine
Copy link
Contributor

Remove yamlCamera.py and change import to obs_base.
Also, set execute bit for the run_all script and add very minimal test
to help future people start adding tests to this package.

Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leery of having a test that does nothing. I suggest either ditching the test or adding some meat to it. If you want to do the latter (which would be great!), I suggest you look in obs_base for a test you'd like to run.

Remove yamlCamera.py and change import to obs_base.
Change config/processCcd.py so that the refObjLoader
uses the same pixel offset as the matcher.
Also, set execute bit for the run_all script.
@mfisherlevine mfisherlevine merged commit 34db908 into master Sep 23, 2017
@ktlim ktlim deleted the tickets/DM-11911 branch August 25, 2018 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants