DM-7384: Updates for pytest #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard restructuing of MemoryTester, setup_module and if __name__ as detailed in sqr-012.lsst.io
Previously these DB connection tests were being skipped by scons. The commit uses a setUp method to allow for the exception to be raised and the test formally "Skipped" under py.test instead of the falsely "Passed" that is reported by the previous test runner.
Standardizes the information in the raised error message by testSelectFluxMag0 and testSelectLsstImages when the DBAuth fails.
| """Initialize the DB connection. Raise SkipTest if unable to access DB.""" | ||
| config = SpatialScaleZeroPointTask.ConfigClass() | ||
| config.selectFluxMag0.retarget(SelectLsstSimFluxMag0Task) | ||
| print config |
There was a problem hiding this comment.
Why is this being printed? Also, print_function to be compliant with the style guide.
No longer catches the very general Exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.