Tickets/dm 5503 #23
Merged
Tickets/dm 5503 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Sep 29, 2016
| class ProcessEimageConfig(ProcessCcdTask.ConfigClass): | ||
|
|
There was a problem hiding this comment.
This extra line looks wrong. And there's supposed to be a blank line after the class docstring.
There was a problem hiding this comment.
I agree it looks funny, but unfortunately it is correct PEP8 and is what autopep8 did to the code. The rules are (at least approximately):
- A blank line is required after the class declaration before the doc string. This looks wrong to me, but it's PEP8.
- A blank line is required before each method definition. This is why the class doc string often has a blank line after it (not because the doc string must be followed by a blank line).
|
|
||
| class ProcessEimageTask(ProcessCcdTask): | ||
|
|
| class SelectLsstSimFluxMag0Config(DatabaseSelectImagesConfig): | ||
|
|
| self.host = "lsst-db.ncsa.illinois.edu" | ||
| self.port = 3306 | ||
|
|
||
|
|
||
| class FluxMagInfo(BaseExposureInfo): | ||
|
|
| class SelectLsstSimFluxMag0Task(pipeBase.Task): | ||
|
|
| class SelectLsstImagesConfig(DatabaseSelectImagesConfig): | ||
|
|
| def setDefaults(self): | ||
| super(SelectLsstImagesConfig, self).setDefaults() | ||
| self.host = "lsst-db.ncsa.illinois.edu" | ||
| self.port = 3306 | ||
|
|
||
|
|
||
| class ExposureInfo(BaseExposureInfo): | ||
|
|
| @@ -103,18 +107,19 @@ def getColumnNames(): | |||
|
|
|||
|
|
|||
| class SelectLsstImagesTask(BaseSelectImagesTask): | |||
|
|
|||
| dateObs = DateTime(49552.28496, DateTime.MJD, DateTime.TAI) | ||
| self.dateAvg = DateTime(dateObs.nsecs(DateTime.TAI) + int(0.5e9*self.exposureTime), DateTime.TAI) | ||
| self.boresightRaDec = IcrsCoord(359.936019771151*degrees, -2.3356222648145*degrees) | ||
| self.boresightAzAlt = Coord(127.158246182602*degrees, (90-40.6736117075876)*degrees) |
r-owen
force-pushed
the
tickets/DM-5503
branch
from
09c937e
to
b0968fa
Compare
|
I fixed the spacing around - added support for darkTime, rebased and pushed |
r-owen
force-pushed
the
tickets/DM-5503
branch
from
b0968fa
to
17f9d72
Compare
r-owen
force-pushed
the
tickets/DM-5503
branch
from
17f9d72
to
4df8510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.