Add DCR model data types #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-10438
branch
from
a0f3ca0
to
6ce27ba
Compare
isullivan
force-pushed
the
tickets/DM-10438
branch
from
6b18f76
to
33bcc87
Compare
parejkoj
reviewed
May 8, 2017
| return self._computeCoaddExposureId(dataId, True) | ||
|
|
||
| def bypass_dcrCoaddId_bits(self, datasetType, pythonType, location, dataId): | ||
| return 1 + 7 + 13*2 + 3 |
There was a problem hiding this comment.
Since this is copied from bypass_deepCoaddId_bits, should it just call that instead?
| @@ -236,6 +236,13 @@ def bypass_deepMergedCoaddId_bits(self, *args, **kwargs): | |||
| def bypass_deepMergedCoaddId(self, datasetType, pythonType, location, dataId): | |||
| return self._computeCoaddExposureId(dataId, False) | |||
|
|
|||
| def bypass_dcrMergedCoaddId_bits(self, *args, **kwargs): | |||
| """The number of bits used up for patch ID bits""" | |||
| return 64 - self._nbit_id | |||
There was a problem hiding this comment.
Should you just call bypass_deepMergedCoaddId_bits directly hear instead?
There was a problem hiding this comment.
Yes, that would be much better. I'll correct all the bypass functions to call the deepCoadd version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.