Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-16294: clean up dataset type definitions #78

Merged
merged 4 commits into from Oct 25, 2018
Merged

Conversation

TallJimbo
Copy link
Member

No description provided.

Copy link
Member

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few more templates that you could remove in this ticket, but since this package is on it's way out it's not necessary.

deepCoadd_measMatch:
template: deepCoadd-results/%(filter)s/%(tract)d/%(patch)s/srcMatch-%(filter)s-%(tract)d-%(patch)s.fits
deepCoadd_measMatchFull:
template: deepCoadd-results/%(filter)s/%(tract)d/%(patch)s/srcMatchFull-%(filter)s-%(tract)d-%(patch)s.fits
deepCoadd_forced_src:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove dcrCoadd_measMatch, dcrCoadd_measMatchFull, dcrCoadd_forced_src, dcrCoadd_forced_config, and dcrCoadd_forced_metadata

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The package may be on its way out, but I bet it's still being copied from at times.

We never got meas_mosaic running on anything other than HSC.
The code that produces these has been dead for years.
There are other templates that differ slightly from those in obs_base,
probably needlessly, but changing them would break our ability to read
old repos (and this package is on its way out), so I'm not going to
touch them.
The definitions of these in obs_base should be fine.
@TallJimbo TallJimbo merged commit 28cebc3 into master Oct 25, 2018
@TallJimbo TallJimbo deleted the tickets/DM-16294 branch October 25, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants