Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-7391: Python 3 #3

Merged
merged 2 commits into from Sep 12, 2016
Merged

DM-7391: Python 3 #3

merged 2 commits into from Sep 12, 2016

Conversation

timj
Copy link
Member

@timj timj commented Sep 12, 2016

No description provided.

@@ -57,7 +59,7 @@ def translator(md):
sex = sex[1:]
else:
sign = +1
dd, mm, ss = map(float, sex.split(":"))
dd, mm, ss = list(map(float, sex.split(":")))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider the (cleaner to me at least) version of:

dd, mm, ss = (float(s) for s in sex.split(":"))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thanks.

@parejkoj parejkoj merged commit ce94b9a into master Sep 12, 2016
@ktlim ktlim deleted the tickets/DM-7391 branch August 25, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants