Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-7346: Pytest support #16

Merged
merged 12 commits into from Sep 1, 2016
Merged

DM-7346: Pytest support #16

merged 12 commits into from Sep 1, 2016

Conversation

fred3m
Copy link
Contributor

@fred3m fred3m commented Aug 30, 2016

No description provided.

@timj timj changed the title Dm 7346 DM-7346: Pytest support Aug 30, 2016
noConnection = False
try:
DbAuth.username(config.selectFluxMag0.host, str(config.selectFluxMag0.port))
except Exception, e:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to write new code please use the modern variant of as e.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I just missed this one when I copied it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from where? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The try...except block was originally in the run function before I updated the boilerplate. I modified it slightly but didn't pay attention to the except syntax.

@fred3m fred3m merged commit f3fba9c into master Sep 1, 2016
@ktlim ktlim deleted the DM-7346 branch August 25, 2018 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants