tickets/dm-7308 Port obs_sdss to Python 3 #23
Conversation
fred3m
force-pushed
the
tickets/DM-7308
branch
from
fe949a0
to
9bdeba2
Compare
fred3m
force-pushed
the
tickets/DM-7308
branch
from
9bdeba2
to
8b0f319
Compare
| @@ -180,6 +180,8 @@ def getColumnNames(): | |||
| "run rerun camcol field filter ra1 dec1 ra2 dec2 ra3 dec3 ra4 dec4".split() + | |||
| "strip psfWidth sky airmass quality isblacklisted".split() | |||
| ) | |||
| def __hash__(self): | |||
| return id(self) | |||
There was a problem hiding this comment.
Might be worth a one-line docstring along the lines of "necessary for hashing this object in python3." or somesuch.
There was a problem hiding this comment.
Good point, I'll add it now
| if npoints < 1: | ||
| raise RuntimeError("Cannot create scaling image. Found no fluxMag0s to interpolate") | ||
|
|
||
| x, z = zip(*sorted(zip(self._xList, self._scaleList))) | ||
| x, z = list(zip(*sorted(zip(self._xList, self._scaleList)))) |
There was a problem hiding this comment.
Ugh. I'm not happy about that line, but I guess we should just leave it?
There was a problem hiding this comment.
I think this is one of those things with no great pythonic solution. If you have a better one I'd be happy to implement it, but unless I'm using numpy arrays I usually use this technique.
| @@ -1,3 +1,5 @@ | |||
| from builtins import str | |||
There was a problem hiding this comment.
Should we not have the import str line in general, to avoid problems like happened with pipe_tasks? See if removing this breaks anything.
There was a problem hiding this comment.
I had forgotten about that. Thanks for the reminder
| @@ -38,11 +41,13 @@ | |||
| # NOTE: commented out to remove astropy.extern.six dependency | |||
There was a problem hiding this comment.
This commented block can be removed (along with the six.PY3 thing), since we now have py3 support.
| @@ -25,6 +25,8 @@ | |||
| """Test lsst.obs.sdss.selectFluxMag0Task and integration with lsst.obs.sdss.scaleSdssZeroPointTask | |||
| """ | |||
| from __future__ import print_function | |||
| from builtins import str | |||
There was a problem hiding this comment.
Another import str we can probably safely remove.
| @@ -22,6 +22,9 @@ | |||
| # see <http://www.lsstcorp.org/LegalNotices/>. | |||
| # | |||
| from __future__ import print_function | |||
| from builtins import str | |||
No description provided.