DM-8467: Wrap lsst_distrib with pybind11 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschella
force-pushed
the
tickets/DM-8467
branch
from
642b56b
to
297f537
Compare
- Fix error calling MaskedImageF copy constructor The original code may have wanted a deep copy (based on the third argument being true) but was specifying origin=LOCAL. Fortunately the code actually wanted origin=LOCAL and had no obvious need for a deep copy (so the True might also have been an unfortunate way of spelling "LOCAL"). I tweaked the code so that the default PARENT origin could be used instead. - Add full `from __future__ import` Our pybind11 wrappers require modern division in some places and all our code should use: ``` from __future__ import absolute_import, division, print_function ``` in any case. I checked for existing cases where `/` relied on returning an integer and found none. In at least once instance (image /= float in NullIsrTask) this change is required in order to run the code with python 2. - Remove obsolete file The file I removed contained one class that raised an exception when any attempt was made to use it and I could find no code that tried to use it.
pschella
force-pushed
the
tickets/DM-8467
branch
from
297f537
to
7f2bc90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.