DM-7913: Implement RFC-240: make Angle's named methods const... #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrap methods were all changed to follow a functional form instead of modifying Angles in place.
kfindeisen
force-pushed
the
tickets/DM-7913
branch
from
a5d65ae
to
a6867f5
Compare
r-owen
reviewed
Mar 9, 2017
| @@ -315,16 +315,13 @@ def checkExpList(self, minRa, maxRa, runExpInfoDict): | |||
| @param[in] maxRa: maxinum RA (degrees) | |||
| @param[in] runExpInfoDict: a dict of run: list of ExposureInfo objects | |||
| """ | |||
| minRaAngle = minRa * afwGeom.degrees | |||
| maxRaAngle = maxRa * afwGeom.degrees | |||
There was a problem hiding this comment.
Please consider updating this test so that the method takes Angle as an argument. I realize it may be out of scope, and it will cascade slightly (e.g. getCoordList will also require the same change) but it's a nice cleanup if you are willing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DM-7913 requested a breaking change in
Angle's API; this was the only package outsideafwto use the wrap methods.