Tickets/DM-11691 Test failure with butler in obs_sdss #36
Conversation
n8pease
force-pushed
the
tickets/DM-11691
branch
from
edfe442
to
8112a07
Compare
There was a problem hiding this comment.
I think I prefer an mkdtemp to be involved or some way to clean up the YAML file that gets written. Is it posible for the _mapper file to have some commentary in it so that people understand what is going on? Or at least add some more text to the associated commit message.
tests/testGetId.py
Outdated
|
|
||
|
|
||
| class GetIdTestCase(lsst.utils.tests.TestCase): | ||
| """Testing butler exposure id retrieval""" | ||
|
|
||
| def setUp(self): | ||
| self.bf = dafPersist.ButlerFactory(mapper=SdssMapper(root=".")) | ||
| self.butler = self.bf.create() | ||
| self.butler = dafPersist.Butler(inputs=os.path.split(ROOT)[0]) |
There was a problem hiding this comment.
Should this be a temp directory rather than an existing directory, given that a yaml file is created that seems to in theory have an effect the next time the test is run?
|
In fact, the test passes if the YAML file is not there, so using a temp directory would make that always true. Is the |
n8pease
force-pushed
the
tickets/DM-11691
branch
from
8112a07
to
1963185
Compare
|
previously where the butler was created with |
|
it seems {} vs None is unrelated. |
No description provided.