DM-20566: Replace afwGeom with geom and fix some resource warnings #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use context managers to ensure that files are closed after opening.
timj
force-pushed
the
tickets/DM-20566-obs_sdss
branch
from
e296ac8
to
a0da2a2
Compare
SimonKrughoff
approved these changes
Jul 23, 2019
| @@ -27,6 +27,7 @@ | |||
| from lsst.afw.cameraGeom import makeCameraFromCatalogs, CameraConfig, DetectorConfig, \ | |||
| TransformMapConfig, SCIENCE, PIXELS, FIELD_ANGLE, FOCAL_PLANE, NullLinearityType | |||
| import lsst.afw.table as afwTable | |||
| import lsst.geom as geom | |||
There was a problem hiding this comment.
There is a stray import of afwGeom on line 25.
There was a problem hiding this comment.
Oh, I see. This is needed for the TransformConfig and transformRegistry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.