DM-7244: Port to Python 3 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getInputRegistry had one trivial change
Remove assertTrue with more specific asserts where practical. No instances of assertEquals or assert_ found
Use full path for lsst.utils.tests and in some other cases to avoid confusion (e.g. when importing Policy from two packages).
Two tests imported TestMapper into the local namespace, which pytest complained about as not being a test class.
| loc = "raw-v%(visit)d-E%(snap)03d-r%(raft)s-s%(sensor)s-c%(channel)s.pickle" % dataId | ||
| loc = os.path.join("tests", "data", "input", loc) | ||
| num = int(raft[0] + raft[2] + sensor[0] + sensor[2] + | ||
| channel[0] + channel[2]) * 10 + snap | ||
| channel[0] + channel[2]) * 10 + snap | ||
| if raft != "0,3" or (snap != 1 and sensor != "0,1"): | ||
| with open(loc, "w") as f: |
There was a problem hiding this comment.
I worry that this pickle file should be opened in "wb" mode. I'm guessing the test never tries to read from the dumped pickle file. Do we have any check to see if we can read this dumped file back again?
There was a problem hiding this comment.
Good catch. This is an obsolete file. I deleted it.
|
|
|
Good catch |
Instead of using a relative path to get to repo data in testPolicyInRepo.py, use the standard getPackageDir technique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.