Create obs_base and make obs_test work with it Tickets/dm 7578 #19
Conversation
| '3': {'visit': 3, 'filter': 'r'} | ||
| } | ||
| self.path_to_raw = os.path.join(self.data_dir, "raw", "raw_v1_fg.fits.gz") | ||
| self.result_ids = {'raw': 1, 'bias': 1, 'flat': 1} |
There was a problem hiding this comment.
I find this name confusing; what kind of IDs does this contain? If it's a visit ID, then result_visits would probably be clearer
There was a problem hiding this comment.
They are exposureIds. I've renamed it. Thanks.
| def setUp(self): | ||
| product_dir = getPackageDir('obs_test') | ||
| self.data_dir = os.path.join(product_dir, 'data', 'input') | ||
| self.Mapper = lsst.obs.test.TestMapper |
There was a problem hiding this comment.
I wonder if you will find you want the class or an instance. If the class, please consider appending Class to the instance variable name, for clarity (self.MapperClass is clearly not an instance of a Mapper)
There was a problem hiding this comment.
I've redone this to be a an instance, instantiated in the child class.
parejkoj
force-pushed
the
tickets/DM-7578
branch
2 times, most recently
from
efcaefe
to
ab30e60
Compare
| super(TestObsTest, self).setUp() | ||
|
|
||
| self.butler = lsst.daf.persistence.Butler(root=self.data_dir) | ||
| self.mapper = lsst.obs.test.TestMapper(root=self.data_dir) |
There was a problem hiding this comment.
This is breaking encapsulation. TestObsTest should only set things that it cares about; it should not have to set up things for its parent class. If something needs to be set up for the parent class, then you should call a method in the parent class to do that. I should be able to change the names of instance variables in the parent class without this subclass knowing anything about it (I know that's not always possible, but it's impossible to such a large extent here that I think it's a bad idea).
parejkoj
force-pushed
the
tickets/DM-7578
branch
3 times, most recently
from
ed2edb9
to
3b16506
Compare
Removed testMap.py, whose contents were lifted into obs_base mapper_tests.py
parejkoj
force-pushed
the
tickets/DM-7578
branch
from
19a4d25
to
3c01277
Compare
No description provided.