obs_test Tickets/dm 8686 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
reviewed
Feb 23, 2017
| _policy: !!python/object:lsst.daf.persistence.policy.Policy | ||
| data: | ||
| exposures: | ||
| raw: {template: raw/v%(visit)d_f%(filter)s.fits.gz} |
There was a problem hiding this comment.
We do not extend our 4-space indent policy to YAML files?
There was a problem hiding this comment.
I didn't even think about it. 2 spaces seems to be the default for yaml.dump. I can specify the indentation level when I call dump though.
@timj is 2 spaces ok or should I specify 4?
There was a problem hiding this comment.
I'm happy with 2, especially if that is the default for YAML serialization.
andy-slac
approved these changes
Feb 23, 2017
Remove use of older, unpublished _policy.paf/yaml mechanism. Rewrite test to use the RepositoryCfg in-repo policy. Rewrite the test to *not* use in-repo policy from parents, which is how it is described in LDM-463. is what is stated in LDM-
and pass them to the superclass
n8pease
force-pushed
the
tickets/DM-8686
branch
from
768cf5b
to
1327e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.