DM-5922: Rework camera geometry to use the replacement for XYTransform #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-5922
branch
from
d33eea8
to
ae71cbd
Compare
TallJimbo
approved these changes
Aug 25, 2017
Rename PUPIL camera system to FIELD_ANGLE Use the new transform factories to produce the right type of transforms.
The camera constructor used the focal plane -> field angle transform in the wrong direction in two instances. Fix this.
r-owen
force-pushed
the
tickets/DM-5922
branch
from
ae71cbd
to
945e3fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.