Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-13849: Convert all ap_verify test data to obs_test #48

Merged
merged 1 commit into from May 25, 2018

Conversation

kfindeisen
Copy link
Member

This PR fixes a bug that prevented config overrides from being used with obs_test calib ingestion. I'm not sure how this slipped through #46, since I called the overrides during testing.

@kfindeisen kfindeisen requested a review from mrawls May 18, 2018 20:13
Copy link

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this import simply unused?

@kfindeisen
Copy link
Member Author

No, the class being imported doesn't exist, causing an ImportError whenever the file was loaded.

Copy link

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fair enough, line be gone!

@kfindeisen kfindeisen merged commit 644c14a into master May 25, 2018
@ktlim ktlim deleted the tickets/DM-13849 branch August 25, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants