Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-13339: shebang needs to be changed in several places in bin.src directories #49

Merged
merged 5 commits into from May 19, 2018
Merged

DM-13339: shebang needs to be changed in several places in bin.src directories #49

merged 5 commits into from May 19, 2018

Conversation

r-owen
Copy link
Contributor

@r-owen r-owen commented May 18, 2018

No description provided.

timj
timj approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I think that from SCons you are only running flake8 on the test files and not the code.

scripts.BasicSConscript.tests(pyList=[])

is needed in the tests/SConcript file.

@r-owen r-owen force-pushed the tickets/DM-13339 branch 2 times, most recently from f4b0699 to 254a5d8 Compare May 18, 2018 23:25
@r-owen
Copy link
Contributor Author

r-owen commented May 18, 2018

Fixed. Thanks for catching that!

@r-owen r-owen merged commit df787ba into master May 19, 2018
@ktlim ktlim deleted the tickets/DM-13339 branch August 25, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-owen @timj