DM-15862: Reduce ISR code duplication between ip_isr, obs_subaru, and obs_decam #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
force-pushed
the
tickets/DM-15862
branch
from
fdf84b0
to
3c4c426
Compare
The ISR code was split between ip_isr and the obs_ packages, with the ip_isr and obs_subaru containing parallel ISR reduction pathways. This ticket merges those pathways into a single set of ISR functions in the ip_isr package, removing the duplication of code. The merged codebase also makes additional useful functions from the obs_subaru ISR available to other cameras, and the new ISR code now profiles debug points, thumbnail images, and post-correction statistics to check processing quality. The testMapper has been updated to persist thumbnail images of the overscan subtracted and flattened ISR images.
czwa
force-pushed
the
tickets/DM-15862
branch
from
3c4c426
to
3a0738a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testMapper has been updated to persist thumbnail images of the
overscan subtracted and flattened ISR images.