New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets/dm-14908: Convert package to numpydoc format #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I can't explicitly approve this pull request, since I created it.
python/lsst/obs/test/dualRawImage.py
Outdated
@@ -20,6 +20,8 @@ | |||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
# | |||
|
|||
__all__ = ("RawAndFlatContainer", "RawAndFlatAssembler", "RawAndFlatDisassembler") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the other packages use a list for __all__
, so I would recommend a list here for consistency.
---------- | ||
md : `lsst.daf.base.PropertySet` | ||
Image metadata. | ||
`dict` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing argDict
?
python/lsst/obs/test/testMapper.py
Outdated
Dataset identifier | ||
Returns | ||
------- | ||
result : str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
str
|
||
Returns | ||
------- | ||
`lsst.afw.image.VisitInfo` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below, include a name for the return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. That used to be optional but I guess it isn't any longer.
8387523
to
f59ec95
Compare
No description provided.