DM-20574: Remove deprecated ip_isr functions from isrFunctions.py #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Nov 8, 2019
data/utils/maskFromDefects.py
Outdated
| @@ -79,7 +78,7 @@ def writeDefectsFile(bboxList, path): | |||
| for bbox in bboxList: | |||
There was a problem hiding this comment.
The line above looks wrong. I don't think we have DefectListT any more. It should say measAlg.Defects() and then the line 81 below could use defectList.maskPixels() directly.
czwa
force-pushed
the
tickets/DM-20574
branch
from
c8f2390
to
4514a96
Compare
czwa
force-pushed
the
tickets/DM-20574
branch
from
4514a96
to
04163ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated isrFunctions/defect methods.