Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-19852: Add deprecation messages around classes that have moved to pipe_tasks #102

Merged
merged 1 commit into from Jul 29, 2022

Conversation

timj
Copy link
Member

@timj timj commented Jul 29, 2022

I've only added the deprecation message to the two classes that were used by our pipeline code.

@timj timj requested a review from erykoff July 29, 2022 15:53
Copy link

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, I think we can move this to v24 because we're still in the between-23-and-24 period, right? But this is more conservative.

@timj
Copy link
Member Author

timj commented Jul 29, 2022

v24 is going to be derived from weekly 28 so we've already missed that. We can though request to backport this ticket to v24 (along with the FocalPlaneBackground changes) and kickstart the deprecation period.

@erykoff
Copy link

erykoff commented Jul 29, 2022

Ah, I didn't realize that! I don't think it's worth the backport trouble.

@timj
Copy link
Member Author

timj commented Jul 29, 2022

I added a backport request in case someone wants to do it.

@timj timj merged commit 1ca1189 into main Jul 29, 2022
@timj timj deleted the tickets/DM-19852 branch July 29, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants