DM-35917: Allow gen3 SkyCorrectionTask to be imported without gen2 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gen2 classes will be loaded if available.
andy-slac
approved these changes
Aug 24, 2022
|
Should work fine in gen3. All the Pool stuff is gen2 only and is completely broken. I don't want to completely delete all the gen2 code from pipe_drivers because there wouldn't be much left and it serves no purpose because pipe_drivers is fundamentally a gen2 package that ended up with some gen3 code in it by mistake. Ideally I would remove pipe_drivers from lsst_distrib (removing ctrl_pool and daf_persistence) but we can't do that because of the gen3 SkyCorrectionTask in there and its deprecation period. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gen2 classes will be loaded if available.