Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/DM 7756 #19

Merged
merged 7 commits into from
Feb 11, 2017
Merged

Tickets/DM 7756 #19

merged 7 commits into from
Feb 11, 2017

Commits on Feb 9, 2017

  1. Run autopep8 on the code

    and perform a few trivial manual cleanups.
    There are a few more substantial warnings that were left alone
    (several list comprehensions that redefine a variable
    and several instances of assigning a variable to a lambda expression)
    r-owen committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    9011194 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2017

  1. Turn foo = lambda into def foo

    ...in order to make the code PEP8 compliant and easier to read.
    r-owen committed Feb 10, 2017
    Configuration menu
    Copy the full SHA
    730c23a View commit details
    Browse the repository at this point in the history
  2. Modernize the code using futurize -1

    This simply changed two instances of `catch Exception, e:`
    to `catch Exception as e:`
    r-owen committed Feb 10, 2017
    Configuration menu
    Copy the full SHA
    a8659a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2017

  1. Make code py2 and py3 compatible

    Modernize with futurize -2
    Group imports properly
    Change `import numpy` to `import numpy as np`
    Add `# noqa` to one line added by futurize to hide a pep8 warning
    r-owen committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    882a02a View commit details
    Browse the repository at this point in the history
  2. remove unneeded list(...)

    futurize added some unnecessary `list(...)` for safety;
    I removed the ones that are not required.
    r-owen committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    53e1ab4 View commit details
    Browse the repository at this point in the history
  3. Remove unneeded .keys()

    r-owen committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    bb56eb4 View commit details
    Browse the repository at this point in the history
  4. Rename variables in list comprehensions

    ...to avoid redefining local variables
    r-owen committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    0c22efb View commit details
    Browse the repository at this point in the history