tickets/DM-10252: Use Butler to retrieve keys in getOutputid() #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
requested changes
Apr 21, 2017
| if self.config.dateObs in dataId: | ||
| dateObs = dataId[self.config.dateObs] | ||
| else: | ||
| dateObs = butler.queryMetadata('raw', ['dateObs'], dataId)[0] |
There was a problem hiding this comment.
Shouldn't this be butler.queryMetadata('raw', [self.config.dateObs], dataId)[0]?
i.e., use the field we're told to, rather than hard-coding dateObs.
| @@ -452,7 +452,8 @@ def getMjd(self, butler, dataId, timescale=dafBase.DateTime.UTC): | |||
|
|
|||
| def getFilter(self, butler, dataId): | |||
| """Determine the filter from a data identifier""" | |||
| return dataId[self.config.filter] | |||
| filt = butler.queryMetadata('raw', ['filter'], dataId)[0] | |||
There was a problem hiding this comment.
This seems like a regression --- hard-coding filter instead of using what we're told to in the config.
There was a problem hiding this comment.
Good catch there, thank you :) (And likewise below)
mfisherlevine
force-pushed
the
tickets/DM-10252
branch
from
acdab29
to
8d335c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.