Change string nan to real nan #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-11653
branch
from
13f243d
to
4ada7cf
Compare
natelust
reviewed
Oct 3, 2017
This parameter is used for a numerical comparison, so strings are just wrong. Chaging nan to inf because we want to print for all values (i.e. less than inf) It should never have been a string, nor should it have been nan.
mfisherlevine
force-pushed
the
tickets/DM-11653
branch
from
4ada7cf
to
a564898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.