Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-6965: multibandDriver: write metadata from detection #38

Merged
merged 1 commit into from Nov 3, 2017

Conversation

PaulPrice
Copy link
Contributor

We now put some useful information in the detection metadata, so we need
to make sure it's clean and write it out.

Not using MultiBandDriverTask.writeMetadata because the 'dataRef' that's
provided there is actually a list of data references, and it's not clear
we can identify which entry in the metadata belongs to which dataRef.

We now put some useful information in the detection metadata, so we need
to make sure it's clean and write it out.

Not using MultiBandDriverTask.writeMetadata because the 'dataRef' that's
provided there is actually a list of data references, and it's not clear
we can identify which entry in the metadata belongs to which dataRef.
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping that using detectCoaddSources.writeMetadata also means we get the same outputs when running DetectCoaddSourcesTask directly as a command-line Task, so I agree it's the right thing to do.

If you haven't already, could you check that doing that (running DetectCoaddSourcesTask directly) also writes metadata?

@PaulPrice
Copy link
Contributor Author

Checked both ways of writing the metadata (detectCoaddSources.py and multibandDriver.py), and both get the value in there. When writing from multiband, you get an extra multiband-specific prefix to the key name (because the Task hierarchy contains that extra level, and the mechanics of writing the metadata respects that) but I figure that's not a big problem (if it is, we can address it on a separate ticket; at least the value is in there).

@PaulPrice PaulPrice merged commit da951ac into master Nov 3, 2017
@ktlim ktlim deleted the tickets/DM-6965 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants