DM-12766: Add __reduce__ to CoaddDriver so to know how to pickle #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
requested changes
Nov 21, 2017
| def __reduce__(self): | ||
| """Pickler""" | ||
| return unpickle, (self.__class__, [], dict(config=self.config, name=self._name, | ||
| parentTask=self._parentTask, log=self.log)) |
There was a problem hiding this comment.
Indent to match paren above.
| def unpickle(factory, args, kwargs): | ||
| """Unpickle something by calling a factory""" | ||
| return factory(*args, **kwargs) | ||
|
|
There was a problem hiding this comment.
Two lines between function and class.
| def __reduce__(self): | ||
| """Pickler""" | ||
| return unpickle, (self.__class__, [], dict(config=self.config, name=self._name, | ||
| parentTask=self._parentTask, log=self.log)) |
There was a problem hiding this comment.
Thanks for the catch. Adding it to MultiBandDriver too.
hsinfang
force-pushed
the
tickets/DM-12766
branch
from
8e41c51
to
5d3342f
Compare
hsinfang
force-pushed
the
tickets/DM-12766
branch
from
5d3342f
to
1492ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running coaddDriver with cores >1 has been producing
MPI_Abort(MPI_COMM_WORLD, 1)