DM-12979: add visualizeVisit #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Dec 13, 2017
| imageFactory=afwImage.ImageF, | ||
| binSize=binning | ||
| ) | ||
| image = visualizeVisit.makeCameraImage(camera, dict(exp for exp in exposures if exp is not None), binning) |
There was a problem hiding this comment.
I don't see how the dict construction can possibly work here. If you pass dict an iterable doesn't each element (e.g. exp) need to be a (key, value) pair? And if so, isn't if exp is not None malformed?
There was a problem hiding this comment.
readImage is returning a key,value pair, so naming the iteration variable exp is a bit misleading. I'll fix that.
PaulPrice
force-pushed
the
tickets/DM-12979
branch
from
388cf09
to
329fdb8
Compare
This provides a facility to produce a binned image of the entire focal plane (butler product visit_camera).
PaulPrice
force-pushed
the
tickets/DM-12979
branch
from
329fdb8
to
db9b501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a facility to produce a binned image of the entire focal
plane (butler product visit_camera).
Useful for viewing the results of the new y-band background subtraction feature.