DM-13260: constructCalibs: check for full visit/ccd set #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rearmstr
approved these changes
Jan 29, 2018
| @@ -194,7 +195,7 @@ def dictToTuple(dict_, keys): | |||
| return tuple(dict_[k] for k in keys) | |||
|
|
|||
|
|
|||
| def getCcdIdListFromExposures(expRefList, level="sensor", ccdKeys=["ccd"]): | |||
| def getCcdIdListFromExposures(expRefList, level="sensor", ccdKeys=["ccd"], visitKeys=["visit"]): | |||
There was a problem hiding this comment.
Good catch. It's vestigial, from before I made checkCcdIdLists a method instead of a free function.
PaulPrice
force-pushed
the
tickets/DM-13260
branch
from
b7a1c7c
to
79cb1fc
Compare
We don't want to combine a different set of inputs for different CCDs (some operations implicitly assume that, e.g., flat-fields), so check the inputs and report if there's a problem.
PaulPrice
force-pushed
the
tickets/DM-13260
branch
from
79cb1fc
to
08f30ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to combine a different set of inputs for different CCDs
(some operations implicitly assume that, e.g., flat-fields), so check
the inputs and report if there's a problem.