DM-13437: Stop calibration product generation from causing lots of warnings/errors due to inability to create pretty pictures #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertLuptonTheGood
approved these changes
Feb 3, 2018
| return imageFactory(1, 1), detId | ||
| return self.images[detId], detId | ||
| image = imageFactory(detector.getBBox()) | ||
| image.set(np.nan) |
There was a problem hiding this comment.
Should this use self.background?
| This requires that the 'ccd name' is a tuple containing only the | ||
| detector ID. If that is not the case, change CalibConfig.ccdKeys | ||
| or set CalibConfig.doCameraImage=False to disable this. | ||
|
|
||
| @param camera Camera object | ||
| @param dataId Data identifier for output |
There was a problem hiding this comment.
With the change from tuple to dataId I think you should update this description
| return self.images[detId], detId | ||
| image = imageFactory(detector.getBBox()) | ||
| image.set(np.nan) | ||
| image = afwMath.binImage(image, binSize) |
There was a problem hiding this comment.
It's wasteful to create a full-size image of NaNs then bin it down. Can't you create the binned image directly?
The dict of calibs has been indexed by the "ccdName" (a tuple of CCD-specific dataId values), but our ImageSource doesn't know how to construct one of those from the detector it's given. Instead, index the calibs by the detector ID.
We have been returning 1x1 images if there's no image, and that generates annoying warnings with cryptic messages. Instead, generate a full-size fake image.
PaulPrice
force-pushed
the
tickets/DM-13437
branch
from
651812d
to
63528f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.