DM-17426: Improve full-visit sky subtraction #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
force-pushed
the
tickets/DM-17426
branch
7 times, most recently
from
859499b
to
b894512
Compare
This task does multiple detection passes to get a good sky level unaffected by the wings of objects. This will be used in constructSky and skyCorrection.
This allows us to more completely remove objects when building the sky frame (useful when there's only a small number of inputs).
This allows a better measurement of the sky level, less affected by the wings of bright objects.
We need to interpolate in two dimensions instead of one, since chip gaps can extend completely across a single dimension of the camera.
This cleans up any remaining low-level sky after the original two stages (large-scale focalplane sky-subtraction and sky frame subtraction).
PaulPrice
force-pushed
the
tickets/DM-17426
branch
from
f1acda7
to
4c9d1b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.