DM-18531: Add Gen3 implementation to skyCorrection.py. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
requested changes
May 20, 2019
| The comments below referencing "match points" should allow | ||
| easier code conversion, as they point out places in the | ||
| runDataRef() and run() methods where it should be possible to | ||
| compare data. |
There was a problem hiding this comment.
This comment block should probably not exist. If we were doing other changes to the stack, it would just be for the code to change according to the ticket, it seems that there should be nothing special for the gen3 work, and more over we have not dont it in other places. If you feel it adds valuable information outside the normal to future developers, add it as a code comment, and not as a documentation comment that will be available through api docs, as this is an internal change that only someone coding against this task should know
| def run(self, calExpArray, calBkgArray, skyCalibs, camera): | ||
| """Duplicate runDataRef method for Gen3. | ||
|
|
||
| This is written to run in serial for now. |
There was a problem hiding this comment.
This does not seem appropriate wording for a docstring
czwa
force-pushed
the
tickets/DM-18531
branch
3 times, most recently
from
daaf626
to
8f2d3ae
Compare
natelust
approved these changes
May 30, 2019
The new Gen3 implementation of the skyCorrection code is serialized, and duplicates some of the SkyCorrectionTask methods to provide this serialized form via a run() method (which matches the Gen2 runDataRef() method). Comments have been added to link the Gen2 and Gen3 methods, and both methods should be updated for any future code changes. An additional "rawLinker" input dataset is needed for Gen3, as the calExp (which has the dataset.visit column populated) cannot find a link to find the appropriate camera/sky calibration entries. Adding this rawLinker allows the calExp to connect to the raw data that was its source, and use that connection to find the calibration files. This dataset is used only for constructing the quantum graph, and is removed prior to processing in the task run() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Gen3 implementation of the skyCorrection code is serialized,
and duplicates some of the SkyCorrectionTask methods to provide this
serialized form via a run() method (which matches the Gen2
runDataRef() method). Comments have been added to link the Gen2 and
Gen3 methods, and both should be updated for any future code changes.
An additional "rawLinker" input dataset is needed for Gen3, as the
calExp (which has the dataset.visit column populated) cannot find a
link to find the appropriate camera/sky calibration entries. Adding
this rawLinker allows the calExp to connect to the raw data that was
its source, and use that connection to find the calibration files.
This dataset is used only for constructing the quantum graph, and is
removed prior to processing in the task run() method.