DM-20548: Update HSC's camera geometry to use units of millimeters #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in FocalPlaneBackgroundConfig() "the focal plane frame is usually defined in units of microns or millimetres rather than pixels. As such, their values will need to be revised according to each particular camera." The algorithm here was developed and battle-tested against HSC in the context of a camera focal plane defined in "pixels", but it is meant to accommodate FPs defined in other units. It turns out one place -- the setting of the threshold for the minimum number of pixels contributing for a bin to be considered "good" -- was failing to accommodate FP units other than "pixel". This accommodation is made here by adding a config defining the size of a detector pixel in the units for which the given camera geoms focal plane is defined.
PaulPrice
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.