DM-29055: Update Connections in SkyCorrectionTask #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
force-pushed
the
tickets/DM-29055
branch
from
cb6a787
to
6a930c5
Compare
TallJimbo
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Just some doc typing corrections.
And this is preexisting, but it might explain a lot - I think the runQuantum implementation needs to sort its input DatasetRef by ref.dataId["detector"] before passing them on to run, which seems to be zip-iterating them on the (dangerous) assumption that they're already consistently ordered.
for changed gen3 interface: - storage class for raws - calibration_label not in use anymore - need lookup function as workaround for inability to query calibration collections
yalsayyad
force-pushed
the
tickets/DM-29055
branch
2 times, most recently
from
54125fa
to
667541a
Compare
yalsayyad
force-pushed
the
tickets/DM-29055
branch
from
667541a
to
ef96781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for changed gen3 interface:
calibration collections