Add missing -L for libyaml #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Jun 21, 2017
ups/eupspkg.cfg.sh
Outdated
| @@ -3,5 +3,5 @@ TAP_PACKAGE=1 | |||
|
|
|||
| build() | |||
| { | |||
| CFLAGS=-I${LIBYAML_DIR}/include python setup.py --with-libyaml build | |||
| CFLAGS="-I${LIBYAML_DIR}/include -L${LIBYAML_DIR}/lib" python setup.py --with-libyaml build | |||
There was a problem hiding this comment.
Why is it added to CFLAGS rather than LDFLAGS?
There was a problem hiding this comment.
Because I didn't know about LDFLAGS? :-) Lemme give that a try...
There was a problem hiding this comment.
LDFLAGS seems to work fine for the container build, and is definitely better. Updated PR and re-running Jenkins...
There was a problem hiding this comment.
CFLAGS is for compilation and LDFLAGS is for linking.
Similar to the previous change for CFLAGS, a -L option is needed on LDFLAGS to find the libyaml library at link on some systems
timj
approved these changes
Jun 21, 2017
|
Sorry, I was on vacation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent pyyaml change to build on top of libyaml busted the Qserv base container builds.
It looks like a necessary -L option for libyaml is missing off the LDFLAGS additions in the build() override in the eupspkg.cfg.sh; in miniconda installs this goes unnoticed since the lib is picked up from miniconda. Since the Qserv base containers are non-miniconda builds, they broke.