Tickets/DM-10848 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop scaling the noise used for fake sources by the amplifier gain as this effect should have been dealt with in ISR
Make the RandomStarFakeSourcesTask able to run with the fake object insertion hooks in the LSST pipeline
Make the RandomGalSimFakesTask able to run with the fake object insertion hooks in the LSST pipeline
Make the PositionGalsimFakes task compatible with the LSST fake object pipeline hooks.
rearmstr
reviewed
Jul 31, 2017
| nStars = lsst.pex.config.Field(dtype=int, default=1, | ||
| doc="Number of stars to add") | ||
| magnitude = lsst.pex.config.Field(dtype=float, default=20.0, | ||
| doc="Magnitude of all stars to be added") | ||
| margin = lsst.pex.config.Field(dtype=int, default=None, optional=True, | ||
| doc="Size of margin at edge that should not be added") | ||
| seed = lsst.pex.config.Field(dtype=int, default=0, | ||
| seed = lsst.pex.config.Field(dtype=int, default=1, |
There was a problem hiding this comment.
Why is the default seed changed to 1?
There was a problem hiding this comment.
Simply because the code fails if the seed is zero with an InvalidParameterError with the current stack. As it was just a seed, I figured the value didnt matter
There was a problem hiding this comment.
I see. Sometimes I've seed=0 mean use the current time stamp, but I don't know if that is the case with our software. If seed=0 is not allowed, than it probably doesn't matter.
There was a problem hiding this comment.
Yeah, this is produced:
lsst.afw.math.Random(seed=0)
---------------------------------------------------------------------------
InvalidParameterError Traceback (most recent call last)
<ipython-input-41-e4860cd80795> in <module>()
----> 1 lsst.afw.math.Random(seed=0)
InvalidParameterError:
File "src/math/Random.cc", line 66, in void lsst::afw::math::Random::initialize()
Invalid RNG seed: 0 {0}
lsst::pex::exceptions::InvalidParameterError: 'Invalid RNG seed: 0'
rearmstr
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.