DM-14842: Fix deprecation warnings from PropertyList/Set.get #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `getScalar` or `getArray` instead of deprecated `get` on `PropertySet` and `PropertyList` instances.
yalsayyad
reviewed
Jun 20, 2018
python/lsst/synpipe/compareModel.py
Outdated
| @@ -103,8 +100,7 @@ def main(root, visit, ccds, galType='sersic', output='outputs/'): | |||
|
|
|||
| npTable = writeNumpyTable(fakeTable) | |||
| rerunName = root.split('/')[-2] | |||
| fitsTable = astropy.table.Table(npTable).write(output+'/'+rerunName + | |||
| '_galMags.txt', format='ascii') | |||
| astropy.table.Table(npTable).write(output+'/'+rerunName + '_galMags.txt', format='ascii') | |||
There was a problem hiding this comment.
Add some extra spaces around the + while you're already editing this line. (Looks like it's not approaching 110)
yalsayyad
reviewed
Jun 20, 2018
| @@ -1,10 +1,5 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Why does this go away and not in python/lsst/synpipe/makeFakeGalaxy.py too?
There was a problem hiding this comment.
I must have missed that one. I'll fix it and a bunch of others.
Note that many of these same modules have if __name__ == "__main__": sections, which don't belong in library code. But I'm leaving them for now.
And make one line easier to read by breaking it into two lines
Add a minimal unit test that imports the library and checks for the presence of a symbol. A unit test is necessary in order to have scons run flake8 reliably and an import test is better than nothing.
|
I fixed the two issues you raised |
yalsayyad
approved these changes
Jun 20, 2018
both by scons and by Travis on github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.