DM-2639: {{Standardize primary method names, run/runDataRef, across PipeTasks}} #12
Conversation
| @@ -26,7 +26,7 @@ class OnlyFakesMergeTask(mBand.MeasureMergedCoaddSourcesTask): | |||
| # OnlyFakesMergeConfig to avoid having to fix overridden config parameters | |||
| ConfigClass = mBand.MeasureMergedCoaddSourcesConfig | |||
|
|
|||
| def run(self, patchRef): | |||
| def runDataRef(self, patchRef): | |||
There was a problem hiding this comment.
I think this class also needs a run method so it can be used when you don't have a dataRef.
There are a few code style violations that are existing (e.g., i_ss, using docstrings instead of comments) that you would be welcome to clean up if you're able.
There was a problem hiding this comment.
This ticket will leave some Tasks without a run method. Refactoring all the Tasks was out of scope for this ticket.
There was a problem hiding this comment.
But the refactoring is not difficult, and it's required to meet the actual goal of the RFC.
There was a problem hiding this comment.
Sounds like we should just make sure those cleanup tickets are also conditions of calling the RFC implemented. I don't think there's anything wrong with a Task that lacks a run method (that wasn't just as wrong before) aside from the fact that this leaves the RFC implementation incomplete.
There was a problem hiding this comment.
This ticket is not final implementation ticket of RFC-352: Please see https://jira.lsstcorp.org/browse/DM-11098 and the comment therein which describes the relationship between 11098 and 2639.
Prepare Tasks for Gen3 PipelineTask conversion by: * Renaming CmdlineTask's entry method to `runDataRef`. The default CmdlineTask.TaskRunner now calls a Task's `runDataRef` method on the parsed command line inputs. `runDataRef` method can take any Gen2 Butler data products. * Renaming CmdlineTasks previous core methods (e.g. assemble, characterize) to `run` when they exist.
Rename methods according to RFC-352.
Fifteen total repositories with changes.