tickets/DM-13808 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
May 2, 2018
python/lsst/synpipe/matchFakes.py
Outdated
| @@ -279,10 +279,17 @@ def getFakeSources(butler, dataId, tol=1.0, | |||
|
|
|||
| if ('pixelScale' in extraCols) or ('thetaNorth' in extraCols): | |||
| wcs = cal.getWcs() | |||
| availExtras['pixelScale']['value'] = wcs.pixelScale().asArcseconds() | |||
| availExtras['pixelScale']['value'] = wcs.getPixelScale().asArcseconds() | |||
| xMid = cal.getWidth() // 2 | |||
There was a problem hiding this comment.
Please add a comment block here describing why all the below is happening, it may not be obvious to future readers
| @@ -103,6 +101,9 @@ def run(self, exposure, background): | |||
| except KeyError: | |||
| raise KeyError("No RA/DEC column in {} table".format(self.config.galList)) | |||
|
|
|||
| skyToPixelMatrix = wcs.linearizeSkyToPixel(galCoord, lsst.afw.geom.degrees) | |||
There was a problem hiding this comment.
add a comment about why the 3600 is necessary (I agree it is, but magic numbers should not be used without some documentation
There was a problem hiding this comment.
The 3600.0 is kept from the previous version of this code the documentation of which is out of the scope of this ticket.
| @@ -68,7 +68,7 @@ def run(self, exposure, background): | |||
|
|
|||
| starXY = wcs.skyToPixel(starCoord) | |||
| bboxI = exposure.getBBox(PARENT) | |||
| bboxI.grow(margin) | |||
| bboxI.grow(int(margin)) | |||
There was a problem hiding this comment.
change the commit message of this from "Misc fixes" to something like "Cast variables to proper types"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.