Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-12205 Add patch for unencoded cpp file #3

Merged
merged 1 commit into from Oct 16, 2017
Merged

Conversation

parejkoj
Copy link
Contributor

No description provided.

@timj
Copy link
Member

timj commented Oct 11, 2017

This might already be fixed upstream. We are deliberately using an old version because of a dependency change. I wonder why this works on Jenkins but fails with your compiler.

@parejkoj
Copy link
Contributor Author

Ah, yes, it does look like it's fixed upstream:

https://github.com/rmjarvis/TreeCorr/blob/releases/3.3/setup.py#L175

As to why Jenkins works but not my machine, it's going to have something to do with the difference between running cc --version on lsst-dev:

$ cc --version
cc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

vs. on my Ubuntu desktop:

$ cc --version
cc (Ubuntu 5.4.0-6ubuntu1~16.04.5) 5.4.0 20160609
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

but I don't feel like trying to figure out what setup.get_compiler is actually doing...

@parejkoj parejkoj merged commit 3a603bc into master Oct 16, 2017
@ktlim ktlim deleted the tickets/DM-12205 branch August 25, 2018 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants