DM-4707: Adapt CFHT astrometry test for DECam COSMOS field validation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| echo "lsst.obs.decam.DecamMapper" > ${INPUT}/_mapper | ||
|
|
||
| RAWDATA=${VALIDATION_DATA_DECAM_DIR} | ||
| ingestImagesDecam.py ${INPUT} ${RAWDATA}/instcal/*.fz --mode link |
There was a problem hiding this comment.
${RAWDATA} needs to be quoted. Consider running shellcheck on the shell scripts.
|
Can you run |
|
Thanks for the nudge to do that. flake8 and shellcode pass The various *Config.py files aren't exactly Python source files so I didn't fuss with them. |
| and validate the astrometry of the results. | ||
|
|
||
| Pre-requisites: install and declare the following | ||
| 1. pipe_tasks from the LSST DM stack (note that pipe_tasks is included with lsst_apps, which is the usual thing to install) | ||
| 2. obs_cfht from https://github.com/lsst/obs_cfht (this package is not included with lsst_apps); declare this with tag "current" | ||
| 3. validation_data_cfht from https://github.com/wmwv/validation_data_cfht | ||
| 3. validation_data_cfht from https://github.com/lsst/validation_data_cfht | ||
| 4. validation_data_decam from https://github.com/lsst/validation_data_decam | ||
|
|
There was a problem hiding this comment.
Yes, thank you. I rewrote this section a bit now that obs_cfht and obs_decam are in lsstsw/etc/repos.yaml.
Generalize astometry check (almost) across CFHT, COSMOS. Need to pass data Id instead of visits, ccd to have generic code that works for different Butler config/mappings.
Add DECam test script to use with validation_data_decam. Use astrometry_net_data catalog in validation_data_decam to do astrometric and photometric calibration for the DECam sample COSMOS data. Updated README with DECam validation and pre-requisites. Explain the options for installing obs_cfht and obs_decam through lsstsw or eups distrib or just yourself. Run validation on CCDs 10-18; expect >10000 matches. Rename *_cfht files to *Cfht.
Part of this changes the call of defaultData() in "__main__" to generically pass its arguments as *args to the main checkAstrometry.run() without explicitly listing each of the arguments on the LHS and then RHS a line later. This was nominally motivated by the line length being too long but seems just like better practice anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.