DM-21950: Update validate_drp to work with different external calibrations #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
requested changes
Nov 25, 2019
| externalPhotoCalibName = Field( | ||
| dtype=str, | ||
| doc=("Type of external PhotoCalib. Currently supported are jointcal, " | ||
| "fgcm, and fgcm_tract."), |
There was a problem hiding this comment.
This looks like it should be a ChoiceField, to get some automatic validation.
There was a problem hiding this comment.
Thanks, I didn't know about the ChoiceField.
erykoff
force-pushed
the
tickets/DM-21950
branch
3 times, most recently
from
53c9def
to
6810312
Compare
parejkoj
approved these changes
Dec 6, 2019
| doApplyExternalPhotoCalib = Field( | ||
| dtype=bool, default=False, | ||
| doc=("Whether to apply external photometric calibration via an " | ||
| "`lsst.afw.image.PhotoCalib` object. Uses the " |
There was a problem hiding this comment.
two spaces? ;-)
Also, I don't think these docstrings need to be wrapped at 80 characters. At least, I hope they don't.
| Parameters | ||
| ---------- | ||
| butler: `lsst.daf.persistence.Butler` | ||
| dataId: Butler dataId |
There was a problem hiding this comment.
Docstrings for these two (and below)? Is the "Butler dataId" a dict or an lsst.daf.persistence.ButlerDataRef?
python/lsst/validate/drp/validate.py
Outdated
| Use jointcal/meas_mosaic outputs to calibrate positions and fluxes. | ||
| doApplyExternalPhotoCalib : bool, optional | ||
| Apply external photoCalib to calibrate fluxes. | ||
| Default is False. |
There was a problem hiding this comment.
Don't need to specify defaults here (and below).
… be used. Configuration options have been updated to allow different external photometric calibrations (e.g. fgcmcal) to be used. The external PhotoCalib and WCS datasets can now be specified separately as well.
erykoff
force-pushed
the
tickets/DM-21950
branch
from
6810312
to
19eac21
Compare
External wcs is now doApplyExternalSkyWcs and externalSkyWcsName.
erykoff
force-pushed
the
tickets/DM-21950
branch
from
19eac21
to
cae20c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update validate_drp so that external photometric and astrometric corrections are separated, and so that fgcmcal can be used in place of jointcal for photometry.