Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disableCc=True to SConstruct. #109

Merged
merged 1 commit into from Dec 3, 2019
Merged

Add disableCc=True to SConstruct. #109

merged 1 commit into from Dec 3, 2019

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Dec 3, 2019

This is a pure-Python package that doesn't need to compile any C++.

This is a pure-Python package that doesn't need to compile any C++.
@timj
Copy link
Member

timj commented Dec 3, 2019

Would you mind fixing the python/lsst/validate/drp/util.py yaml.load warnings whilst you are here? It might be that a trivial change to use safe_load will fix the warnings.

@wmwv
Copy link
Contributor Author

wmwv commented Dec 3, 2019

I'm going to do the safe_load on a separate ticket because I actually want to test and make sure the safe_load works beyond just making sure the Jenkins run passes. E.g., I'm concerned that changing the yaml loading may change the logic of what validate_drp actually tries to do -- it still might succeed but it might skip half the tests. So I'm going to read the outputs, etc. for such an update.

@wmwv wmwv merged commit 56910ad into master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants