DM-22138: validateDrp arguments (including brightSnr) not passed/parsed correctly #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcarlin
requested changes
Mar 3, 2020
There was a problem hiding this comment.
I was going to test this implementation by running the command line task validateDrp.py. To enable this (and setting SNR limits for all methods in validate_drp), it seems like you need to update validate.run and runOneRepo to also require the brightSnr argument.
The rest of the changes look good.
brightSnr previously defaulted to 50 and could not be overridden. It is now renamed to brightSnrMin and explicitly set to 50.
taranu
force-pushed
the
tickets/DM-22138
branch
from
cdda12b
to
bf0bd5e
Compare
taranu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.