DM-22803: Only make a plot if there are data to plot #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in matplotlib3.1/astropy4 that now leads to the second plot raising an exception if there are no data. For now workaround by not even trying to do the plot. See Astropy issue: astropy/astropy#9841
SimonKrughoff
approved these changes
Jan 7, 2020
| @@ -118,8 +118,9 @@ def plotAstrometryErrorModel(dataset, astromModel, outputPrefix=''): | |||
|
|
|||
| ax[0].hist(dist, bins=100, color=color['all'], | |||
There was a problem hiding this comment.
Are we confident that dist will always be non-zero length, or is the statement that if dist is zero length we better except because we have bigger problems?
There was a problem hiding this comment.
I hadn't really thought about the general case of someone passing in an empty dataset for plotting. Maybe it should raise a ValueError as soon as numMatched is calculated?
There was a problem hiding this comment.
Or maybe you expect an empty plot? I'll merge this as is and worry about the other problem later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in matplotlib3.1/astropy4 that now leads to
the second plot raising an exception if there are no
data. For now workaround by not even trying to do the plot.
See Astropy issue: astropy/astropy#9841