DM-23258: Add explicit check for existence of source catalog. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
reviewed
Jan 31, 2020
| @@ -282,6 +282,10 @@ def _loadAndMatchCatalogs(repo, dataIds, matchRadius, | |||
| srcVis = SourceCatalog(newSchema) | |||
|
|
|||
| for vId in dataIds: | |||
| if not butler.datasetExists('src', vId): | |||
| print("Could not find source catalog for ", vId) | |||
There was a problem hiding this comment.
I suggest: print(f"Could not find source catalog for {vId}; skipping this dataId.")
... especially if this line could get printed out many times; I would personally find it annoying to have lots of mostly redundant "Skipping this dataId" messages cluttering the logs. If it's only a few then it's not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.