Rewrite np.percentile section to handle units for AstroPy 3, 4. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Feb 11, 2020
|
|
||
| # In AstroPy 3, numpy.percentitle of an array with quantities | ||
| # (incorrectly) returns a unitless number | ||
| # In AstroPy 4, numpy.percentitle of an array with Quantities |
There was a problem hiding this comment.
I think it's Astropy4+numpy >=1.17.
| # In AstroPy 3, numpy.percentitle of an array with quantities | ||
| # (incorrectly) returns a unitless number | ||
| # In AstroPy 4, numpy.percentitle of an array with Quantities | ||
| # correct returns a number with the same units as the input array. |
timj
reviewed
Feb 11, 2020
| # 1. Extract the array in marcsec and convert to a value. | ||
| # 2. Calculate the numpy.percentitle of this unitless array | ||
| # 3. Multiply that result by u.marcsec to get the right units. | ||
| rmsDistMas = amx.extras['rmsDistMas'].quantity.to(u.marcsec).value, |
There was a problem hiding this comment.
There's a comma at the end of this line that should not be there.
|
I also needed to apply this patch: diff --git a/python/lsst/validate/drp/calcsrd/pa2.py b/python/lsst/validate/drp/calcsrd/pa2.py
index 6dd6c0a..8b98c47 100644
--- a/python/lsst/validate/drp/calcsrd/pa2.py
+++ b/python/lsst/validate/drp/calcsrd/pa2.py
@@ -59,5 +59,5 @@ def measurePA2(metric, pa1, pf1_thresh):
magDiffs = pa1.extras['magDiff'].quantity[0, :]
pf1Percentile = 100.*u.percent - pf1_thresh
- return Measurement(metric, np.percentile(np.abs(magDiffs), pf1Percentile.value) * magDiffs.unit,
+ return Measurement(metric, np.percentile(np.abs(magDiffs.value), pf1Percentile.value) * magDiffs.unit,
extras=datums) |
|
The one other use of I think that one is fine as is. |
wmwv
force-pushed
the
tickets/DM-23414
branch
from
e6d0cd3
to
b33ae6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.